Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try: Add paid newsletter importer #92095

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Try: Add paid newsletter importer #92095

merged 11 commits into from
Jul 17, 2024

Conversation

enejb
Copy link
Member

@enejb enejb commented Jun 25, 2024

Proposed Changes

  • Add special Paid Importer flow for substack.
  • This is a just a skeleton flag PR that we can then user to build other things on top.

Why are these changes being made?

See p9Jlb4-cwn-p2

Testing Instructions

visit
/import/newsletter/substack/$site

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Jun 25, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • odyssey-stats
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/paid-importer-try on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Jun 25, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~154 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         -264 B  (-0.0%)     -109 B  (-0.0%)
entry-login                 -264 B  (-0.0%)     -109 B  (-0.0%)
entry-domains-landing       -264 B  (-0.0%)     -109 B  (-0.1%)
entry-browsehappy           -264 B  (-0.1%)     -109 B  (-0.2%)
entry-stepper               -191 B  (-0.0%)     -132 B  (-0.0%)
entry-main                  -191 B  (-0.0%)     -131 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~9107 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
import                         +43253 B  (+9.4%)   +12804 B  (+9.1%)
with-theme-assembler-flow        -416 B  (-0.7%)      -30 B  (-0.3%)
update-options-flow              -416 B  (-0.9%)      -34 B  (-0.6%)
update-design-flow               -416 B  (-0.0%)      -31 B  (-0.0%)
trial-wooexpress-flow            -416 B  (-0.8%)      -31 B  (-0.4%)
tailored-ecommerce-flow          -416 B  (-0.8%)      -34 B  (-0.5%)
site-setup-wg                    -416 B  (-0.6%)      -33 B  (-0.2%)
site-setup-flow                  -416 B  (-0.6%)      -32 B  (-0.2%)
site-migration-flow              -416 B  (-0.7%)      -32 B  (-0.3%)
readymade-template-flow          -416 B  (-0.3%)      -33 B  (-0.1%)
migration-signup                 -416 B  (-0.8%)      -32 B  (-0.4%)
import-flow                      -416 B  (-0.8%)      -34 B  (-0.4%)
hosted-site-migration-flow       -416 B  (-0.7%)      -31 B  (-0.3%)
free-post-setup-flow             -416 B  (-0.9%)      -34 B  (-0.6%)
free-flow                        -416 B  (-0.8%)      -33 B  (-0.4%)
entrepreneur-flow                -416 B  (-0.4%)      -32 B  (-0.1%)
assembler-first-flow             -416 B  (-0.6%)      -39 B  (-0.3%)
ai-assembler-flow                -416 B  (-0.6%)      -32 B  (-0.2%)
patterns                         +299 B  (+0.0%)     -100 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~100 bytes removed 📉 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-comment-block-editor                                                   +299 B  (+0.0%)     -100 B  (-0.0%)
async-load-automattic-global-styles-src-components-global-styles-variations       +299 B  (+0.0%)     -100 B  (-0.0%)
async-load-automattic-design-preview                                              +299 B  (+0.0%)     -100 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@enejb enejb self-assigned this Jul 11, 2024
@enejb enejb marked this pull request as ready for review July 11, 2024 21:11
@enejb enejb requested a review from a team as a code owner July 11, 2024 21:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 11, 2024
@enejb enejb requested a review from a team July 11, 2024 21:11
@enejb enejb added the Site Importer Site Importer related issues label Jul 11, 2024
] }
/>

<FormattedHeader headerText={ translate( 'Import your newsletter' ) } />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we wait for the copies to be final before using translate so this doesn't get sent to translators?

client/my-sites/importer/index.js Outdated Show resolved Hide resolved
@lezama
Copy link
Contributor

lezama commented Jul 17, 2024

Screenshot 2024-07-16 at 9 39 42 PM needs padding 😄

@enejb enejb merged commit dadca95 into trunk Jul 17, 2024
11 checks passed
@enejb enejb deleted the add/paid-importer-try branch July 17, 2024 17:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 17, 2024
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
* Add: Newsletter Paid Importer substack config

* Add: Newsletter paid importer

* Add content importing

* Update content.tsx

Removed empty useEffect

* Update importer.tsx

Remove translations

* Update importNewsletterSite to importSubstackSite

* Add select newsletter form step

* Fix type Defintions in the unit tests

* More Props fixes

* Check for existance

* Check for newsletterUrl
gabrielcaires pushed a commit that referenced this pull request Jul 22, 2024
* Add: Newsletter Paid Importer substack config

* Add: Newsletter paid importer

* Add content importing

* Update content.tsx

Removed empty useEffect

* Update importer.tsx

Remove translations

* Update importNewsletterSite to importSubstackSite

* Add select newsletter form step

* Fix type Defintions in the unit tests

* More Props fixes

* Check for existance

* Check for newsletterUrl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Importer Site Importer related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants