-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: Add paid newsletter importer #92095
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~154 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~9107 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~100 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
bfcce07
to
53cdd45
Compare
] } | ||
/> | ||
|
||
<FormattedHeader headerText={ translate( 'Import your newsletter' ) } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we wait for the copies to be final before using translate so this doesn't get sent to translators?
Removed empty useEffect
Remove translations
8551a3f
to
bd7f89f
Compare
* Add: Newsletter Paid Importer substack config * Add: Newsletter paid importer * Add content importing * Update content.tsx Removed empty useEffect * Update importer.tsx Remove translations * Update importNewsletterSite to importSubstackSite * Add select newsletter form step * Fix type Defintions in the unit tests * More Props fixes * Check for existance * Check for newsletterUrl
* Add: Newsletter Paid Importer substack config * Add: Newsletter paid importer * Add content importing * Update content.tsx Removed empty useEffect * Update importer.tsx Remove translations * Update importNewsletterSite to importSubstackSite * Add select newsletter form step * Fix type Defintions in the unit tests * More Props fixes * Check for existance * Check for newsletterUrl
Proposed Changes
Why are these changes being made?
See p9Jlb4-cwn-p2
Testing Instructions
visit
/import/newsletter/substack/$site
Pre-merge Checklist