New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure updated $cache_path ends in '/' #77

Merged
merged 1 commit into from Feb 3, 2017

Conversation

Projects
None yet
3 participants
@omegadrh
Contributor

omegadrh commented Nov 20, 2015

basename() removes the trailing slash, which is expected in the $cache_path variable / config file. Without this fix, you can enter /some/path/wp-content/cache/ and end up with /some/path/wp-content/cachesupercache/ , .../wp-content/cachemeta/ , etc.

Also, don't bother updating the config file if the path hasn't changed.

Make sure updated $cache_path ends in '/'
basename() removes the trailing slash, which is expected in the $cache_path variable / config file. Without this fix, you can enter /some/path/wp-content/cache/ and end up with /some/path/wp-content/cachesupercache/ , .../wp-content/cachemeta/ , etc.

Also, don't bother updating the config file if the path hasn't changed.

@kraftbj kraftbj added the bug label Nov 24, 2015

@kraftbj kraftbj added this to the 1.4.7 milestone Nov 24, 2015

@kraftbj

This comment has been minimized.

Show comment
Hide comment
@kraftbj

kraftbj Nov 24, 2015

Contributor

Looks good to me. Going to get a second 👍.

Contributor

kraftbj commented Nov 24, 2015

Looks good to me. Going to get a second 👍.

@donnchawp donnchawp merged commit 1d62de9 into Automattic:master Feb 3, 2017

kraftbj pushed a commit that referenced this pull request Feb 9, 2017

donncha
* Github merge:
* Make sure $cache_path has a trailing slash (#77)
* Remove flush() (#127) but also check if headers are empty and flush and get headers again. (#179)
* Add fix for customizer (#161) and don't cache PUT AND DELETE requests (#178)
* Check for superglobals before using them. (#131)



git-svn-id: http://plugins.svn.wordpress.org/wp-super-cache/trunk@1588365 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment