Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

WIP: TVM implementation for lidar_point_pillars node #23

Merged

Conversation

luca-fancellu
Copy link
Contributor

@luca-fancellu luca-fancellu commented Oct 15, 2020

New feature implementation

Implemented feature

Add TVM support to the lidar_point_pillars node

Implementation description

Add TVM support to use TVM and compiled models to the lidar_point_pillars node, the feature can be enabled passing TVM_AVAIL=ON to CMake.

This PR depends on this other one: autowarefoundation/autoware_ai_common#13

@LiyouZhou
Copy link

@luca-fancellu can you have a look at the CI failures please?

@luca-fancellu
Copy link
Contributor Author

@luca-fancellu can you have a look at the CI failures please?

Failure are due to the tvm_utility package that is not yet merged (autowarefoundation/autoware_ai_common#13)

Add TVM implementation for the lidar_point_pillars node, it can be
activated by passing the parameter TVM_AVAIL=ON to CMake.

Issue-Id: SCM-1078
Change-Id: Id7516ba13c852b1d82a8bcdc276b3d8b82588ed4
Signed-off-by: Luca Fancellu <luca.fancellu@arm.com>
@JWhitleyWork
Copy link

@luca-fancellu autowarefoundation/autoware_ai_common#13 is now merged. Please modify this implementation to depend on tvm_utility and tvm_vendor.

@luca-fancellu
Copy link
Contributor Author

@luca-fancellu Autoware-AI/common#13 is now merged. Please modify this implementation to depend on tvm_utility and tvm_vendor.

Thank you @JWhitleyWork, @ambroise-arm has just pushed a commit to do that, the CI is also happy

@ambroise-arm
Copy link
Contributor

Note: autowarefoundation/modelzoo#25 allows generating the right header extension (depending on the use of autoware.ai or autoware.auto) in the tvm_models files when using TVM_AVAIL=ON.

lidar_point_pillars/CMakeLists.txt Outdated Show resolved Hide resolved
lidar_point_pillars/CMakeLists.txt Show resolved Hide resolved
lidar_point_pillars/package.xml Outdated Show resolved Hide resolved
add tvm_vendor 0.7.2 dependency

Issue-Id: SCM-1713
Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Change-Id: I90735bb623baebcd2594b8e57a7b4336d88beb00
@JWhitleyWork JWhitleyWork merged commit efdbff0 into autowarefoundation:master Jan 19, 2021
@luca-fancellu luca-fancellu deleted the feature/point_pillars_tvm branch January 19, 2021 15:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants