Update _gLobal_config_checker.py #65
Conversation
Add a warning checker to verify the value of the repository_type
There was a problem hiding this comment.
Hello @bobbyshermi, thank you for your contribution to Taipy. We are really appreciate your help.
Could you please add a test case to the test_gLobal_config_checker.py so we can run the test and make sure everything is correct on all environments?
Otherwise, I only have some small comments on the code.
Add tests on global config checker
Update test_gLobal_config_checker.py
Co-authored-by: Đỗ Trường Giang <dtr.giang.1299@gmail.com>
|
Thank you for the review. I updated the checker to match your remarks and I created some unit tests. |
There was a problem hiding this comment.
It looks good to me. Thank you very much.
FYI, we target to add it in the release 2.3 planned for June.
But merging it will require some work on the enterprise version on our side. I hope we will have time to make it before the release.
We let you know anyway.
Thank you again.
There was a problem hiding this comment.
@bobbyshermi
Love what you did! Thank you for contributing to Taipy!!
I think we're ready to merge this ticket!! Though there's some minor proposal from me (inspired by @trgiangdo) to make it easier for expansion and maintenance. Let me know what you think!!!
There was a problem hiding this comment.
@bobbyshermi
I think we're ready to merge this ticket!! Though there's some minor proposal from me (inspired by @trgiangdo) to make it easier for expansion and maintenance. Let me know what you think!!!
Issue 61 on taipy-config
Add a warning checker to verify the value of the repository_type is either sql or filesystem.