Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update _gLobal_config_checker.py #65

Merged
merged 5 commits into from
May 29, 2023
Merged

Update _gLobal_config_checker.py #65

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c5ecd5
Update _gLobal_config_checker.py
bobbyshermi May 17, 2023
b3ce2df
Update test_gLobal_config_checker.py
bobbyshermi May 18, 2023
13e9d62
Merge pull request #1 from bobbyshermi/patch-1
bobbyshermi May 18, 2023
da05d65
Update src/taipy/config/checker/_checkers/_gLobal_config_checker.py
bobbyshermi May 18, 2023
04feac0
Update _gLobal_config_checker.py
bobbyshermi May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/taipy/config/checker/_checkers/_gLobal_config_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,19 @@ def __init__(self, config: _Config, collector: IssueCollector):
def _check(self) -> IssueCollector:
global_config = self._config._global_config
self._check_clean_entities_enabled_type(global_config)
self._check_repository_type(global_config)
return self._collector

def _check_repository_type(self, global_config: GlobalAppConfig):
value = global_config.repository_type
if value != "filesystem" and value != "sql":
bobbyshermi marked this conversation as resolved.
Show resolved Hide resolved
self._warning(
global_config._REPOSITORY_TYPE_KEY,
value,
f"unknown value: {value} for field {global_config._REPOSITORY_TYPE_KEY}. Default value 'filesystem' is applied.")
bobbyshermi marked this conversation as resolved.
Show resolved Hide resolved

def _check_clean_entities_enabled_type(self, global_config: GlobalAppConfig):
value = global_config._clean_entities_enabled

if isinstance(global_config._clean_entities_enabled, str):
try:
value = tpl._replace_templates(
Expand Down