Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor - Cleaner Code & Stability #1007

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

trgiangdo
Copy link
Member

Follow up the outdated PR #609 from a contributor

FredLL-Avaiga
FredLL-Avaiga previously approved these changes Mar 19, 2024
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, tx @trgiangdo

taipy/gui_core/_adapters.py Outdated Show resolved Hide resolved
toan-quach
toan-quach previously approved these changes Mar 19, 2024
Copy link
Member

@toan-quach toan-quach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

github-actions bot commented Mar 19, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
17745 15617 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
taipy/core/_entity/submittable.py 95% 🟢
taipy/core/_orchestrator/_orchestrator.py 93% 🟢
taipy/core/_repository/_sql_repository.py 88% 🟢
taipy/core/_repository/db/_sql_connection.py 95% 🟢
taipy/core/_version/_utils.py 100% 🟢
taipy/core/_version/_version_manager.py 95% 🟢
taipy/core/_version/_version_mixin.py 100% 🟢
taipy/core/common/_utils.py 100% 🟢
taipy/core/config/checkers/_config_id_checker.py 100% 🟢
taipy/core/config/checkers/_data_node_config_checker.py 98% 🟢
taipy/core/config/checkers/_scenario_config_checker.py 100% 🟢
taipy/core/config/checkers/_task_config_checker.py 100% 🟢
taipy/core/config/data_node_config.py 98% 🟢
taipy/core/config/job_config.py 96% 🟢
taipy/core/config/scenario_config.py 97% 🟢
taipy/core/cycle/cycle.py 98% 🟢
taipy/core/data/_abstract_sql.py 84% 🟢
taipy/core/data/_data_manager.py 98% 🟢
taipy/core/data/_filter.py 91% 🟢
taipy/core/data/aws_s3.py 95% 🟢
taipy/core/data/csv.py 97% 🟢
taipy/core/data/data_node.py 98% 🟢
taipy/core/data/excel.py 86% 🟢
taipy/core/data/generic.py 98% 🟢
taipy/core/data/mongo.py 89% 🟢
taipy/core/job/_job_manager.py 100% 🟢
taipy/core/notification/_topic.py 95% 🟢
taipy/core/scenario/_scenario_manager.py 97% 🟢
taipy/core/sequence/_sequence_manager.py 95% 🟢
taipy/core/submission/submission.py 96% 🟢
taipy/core/task/task.py 96% 🟢
taipy/gui/_renderers/factory.py 96% 🟢
taipy/gui/extension/library.py 88% 🟢
taipy/gui/gui.py 82% 🟢
taipy/gui/utils/_evaluator.py 88% 🟢
taipy/gui/utils/html.py 100% 🟢
taipy/gui_core/_adapters.py 56% 🟢
taipy/gui_core/_context.py 59% 🟢
taipy/rest/api/resources/cycle.py 100% 🟢
taipy/rest/api/resources/datanode.py 96% 🟢
taipy/rest/api/resources/job.py 96% 🟢
taipy/rest/api/resources/scenario.py 100% 🟢
taipy/rest/api/resources/sequence.py 98% 🟢
taipy/rest/api/resources/task.py 98% 🟢
taipy/rest/commons/apispec.py 82% 🟢
taipy/rest/commons/encoder.py 58% 🟢
TOTAL 93% 🟢

updated for commit: b2a070d by action🐍

@jrobinAV
Copy link
Member

It does not pass the linter.

@trgiangdo trgiangdo dismissed stale reviews from toan-quach and FredLL-Avaiga via b2a070d March 19, 2024 14:54
@trgiangdo trgiangdo force-pushed the refactor/continue#609-cleaner-code-and-stability branch from a0ad680 to b2a070d Compare March 19, 2024 14:54
@trgiangdo trgiangdo self-assigned this Mar 19, 2024
@trgiangdo trgiangdo merged commit 5dc674c into develop Mar 20, 2024
150 of 152 checks passed
@trgiangdo trgiangdo deleted the refactor/continue#609-cleaner-code-and-stability branch March 20, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Improvement Improvement of a feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants