Accept Pandas Series in lov property

[Satoshi-Sh]

Related Issue

Fixes #1444

Updates

• Add a condition to convert a pandas.Series to a list in the _adapter.py
• Add a new test case to test_selector.py

Comments

I made a new test case for pd.Series but it doesn't pass. Can you have a look at it?

[FlorianJacta]

This issue is, in fact, still being discussed with the R&D. We will get back to you when the R&D agrees

[Satoshi-Sh]

Got it. Is it better to close this or fine to keep this as is? @FlorianJacta

[FlorianJacta]

Let's keep it for the moment

[FredLL-Avaiga]

simple and efficient
Could you update your branch ?

[Satoshi-Sh]

It's updated but the test I wrote fails for some reason. Can you have a look at it?

[FredLL-Avaiga]

you also need to manage the type in builder.py (for the default value) in def __get_list_of()
I would recommend a generic approach

if not isinstance(lof, list) and hasattr(lof, "tolist"):
            try:
                return lof.tolist()  #type: ignore[union-attr]
            except Exception as e:
                _warn("Error accessing List of values", e)

[FredLL-Avaiga]

If you update your branch and resolve the conversations, I think we can merge this branch.

[Satoshi-Sh]

@FredLL-Avaiga Resolved conversations and updated the branch.

[FredLL-Avaiga]

I'd like @FabienLelaquais and @dinhlongviolin1 to take a look

[FabienLelaquais]

d with the R&D. We will get back to you when the R&D agrees

On it, @FredLL-Avaiga

[FabienLelaquais]

This is really simple and clear.
I added a comment just in case. Do it or not. Let me know.
No problem to approve+merge then.

[FabienLelaquais]

👌

[FredLL-Avaiga]

Thank you @Satoshi-Sh

[Satoshi-Sh]

Thanks for your help, Fred 🚀