Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#1429 number step attribute #1469

Merged
merged 25 commits into from
Jul 4, 2024
Merged

Feature/#1429 number step attribute #1469

merged 25 commits into from
Jul 4, 2024

Conversation

namnguyen20999
Copy link
Member

resolve #1429

namnguyen20999 and others added 10 commits June 22, 2024 16:58
FabienLelaquais
FabienLelaquais previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with that!

frontend/taipy-gui/src/components/Taipy/Input.tsx Outdated Show resolved Hide resolved
frontend/taipy-gui/src/components/Taipy/Input.tsx Outdated Show resolved Hide resolved
frontend/taipy-gui/src/components/Taipy/Input.tsx Outdated Show resolved Hide resolved
taipy/gui/_renderers/factory.py Outdated Show resolved Hide resolved
FredLL-Avaiga
FredLL-Avaiga requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't handle the shift arrow if we're not in a number text field

frontend/taipy-gui/src/components/Taipy/Input.tsx Outdated Show resolved Hide resolved
FredLL-Avaiga
FredLL-Avaiga previously requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@FredLL-Avaiga FredLL-Avaiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there

frontend/taipy-gui/src/components/Taipy/Input.tsx Show resolved Hide resolved
frontend/taipy-gui/src/components/Taipy/Input.tsx Show resolved Hide resolved
frontend/taipy-gui/src/components/Taipy/Input.tsx Outdated Show resolved Hide resolved
@FredLL-Avaiga
Copy link
Member

please update your branch

FabienLelaquais
FabienLelaquais requested changes Jul 4, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good.
A small error in the doc file though.

taipy/gui/viselements.json Outdated Show resolved Hide resolved
taipy/gui/viselements.json Outdated Show resolved Hide resolved
FabienLelaquais
FabienLelaquais approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@FabienLelaquais FabienLelaquais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@namnguyen20999 namnguyen20999 dismissed FredLL-Avaiga’s stale review July 4, 2024 19:23

all comments has been resolved

@namnguyen20999 namnguyen20999 merged commit e42f1c4 into develop Jul 4, 2024
62 of 64 checks passed
@namnguyen20999 namnguyen20999 deleted the feature/#1429-number-step-attribute branch July 4, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabienLelaquais FabienLelaquais FabienLelaquais approved these changes

@dinhlongviolin1 dinhlongviolin1 Awaiting requested review from dinhlongviolin1

@FredLL-Avaiga FredLL-Avaiga Awaiting requested review from FredLL-Avaiga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The number visual element number should have property type step.
3 participants
@namnguyen20999 @FredLL-Avaiga @FabienLelaquais