Feat/provider filter #1355
Draft
Feat/provider filter #1355
+104
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjnewman
requested review from
jordan-a-young,
LauRoxx and
gregmartDOTin
as code owners
bjnewman
force-pushed
the
feat/provider-filter
branch
from
2045fac
to
758f165
Compare
|
i forgot to account for the fact that parameters can be a function, will update the PR in a bit to address this |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
+ Coverage 91.40% 91.54% +0.13%
==========================================
Files 20 21 +1
Lines 733 745 +12
Branches 243 245 +2
==========================================
+ Hits 670 682 +12
Misses 63 63 ☔ View full report in Codecov by Sentry. |
|
converting to draft - it turns out that more internal discussion is needed before this change can be made ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering all providers unless devs pass in searchAll prop.