Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate @av/workflow-settings causes errors in plugins #199

Closed
robmcguinness opened this issue Apr 3, 2019 · 0 comments · Fixed by #211
Closed

duplicate @av/workflow-settings causes errors in plugins #199

robmcguinness opened this issue Apr 3, 2019 · 0 comments · Fixed by #211

Comments

@robmcguinness
Copy link
Contributor

robmcguinness commented Apr 3, 2019

When npm fails to dedupe @av/workflow-settings, then two copies will be created within node_modules: (1) at root level (2) inside @availity/workflow-plugin-*. When this happens, settings.init() is only called in one of the settings modules (root level). The plugin expect settings to be initialized when calling any of its properties.

Possible solution: Pass settings into the plugins so only one copy is referenced:

webpackConfig = plugin('webpack.config')(settings);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant