Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for typeorm streams #221

Merged

Conversation

TylerHAtkinson
Copy link
Contributor

Description

Overriding the stream method from the parent PostgresQueryRunner to set/reset the rls variables. Without this unrecognized configuration parameter "rls.tenant_id" is thrown when trying to use streams

Adding dev dependency on pg-query-stream, which typeorm will try to load when using streams.
https://github.com/typeorm/typeorm/blob/83567f533482d0170c35e2f99e627962b8f99a08/src/driver/postgres/PostgresDriver.ts#L1431

Type of change

Please select the options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change which does not add functionality)

Checklist:

  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@TylerHAtkinson TylerHAtkinson marked this pull request as ready for review February 14, 2024 14:35
@stelescuraul stelescuraul self-assigned this May 7, 2024
@stelescuraul stelescuraul added the enhancement New feature or request label May 7, 2024
@TylerHAtkinson
Copy link
Contributor Author

Hey @stelescuraul thanks for helping get my other pr through, could you also take a look at this one?

@stelescuraul stelescuraul merged commit 70963bc into Avallone-io:master Jul 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants