Support Clipping to rounded corners

[danwalmsley]

If you have something like:

<Border Height="40" Background="Red" Width="100" BorderBrush="Green" BorderThickness="1" CornerRadius="5">
        <Border Width="40" Background="Blue" HorizontalAlignment="Right" />
      </Border>

the containing border will have round corners, but with the inner border overlaying the right hand corners.

WPF would also produce the same result, but UWP would correctly clip the corners like so.

I think this would be an advantage to allow the UWP behaviour and would greatly help in polishing controls.

[frederik-hoeft]

Any updates on this? Is it currently possible at all to achieve this behavior, even with an ugly workaround?

[maxkatz6]

Doesn't ClipToBounds property fix it now?

[dlukach]

the problem with cliptobounds is the background of the control in a border will still overlap the border. Would be nice if the border overlaps the child control to avoid this issue.

[davidackemandev]

^ Here is a screenshot showing what happens when you add ClipToBounds="True" to a parent element. The child element still overlaps with the border.

[Gillibald]

The GeometryClip feature is needed to support this

[maxkatz6]

Probably box-sizing from CSS solves similar problem in web. And not sure about UWP, but I think it's configurable there with BackgroundSizing. Can somebody say, who are familiar with them, if I am right about these properties?

Apart from that, I see only one good and not ugly solution - set corner radius also on child element. Still it might be not convenient. Also we can't just follow UWP approach without any way to configure it, because some applications might depend on that WPF-like behavior.

[davidackemandev]

In CSS you can set overflow="hidden" to clip the child element correctly: codepen

I tried setting a corner radius on the child element, but it still isn't perfect, both parent and child have corner radius = 6:

Does corner radius in Avalonia/WPF scale based on the element's width?

[Gillibald]

Corner radius depends on the borders thickness. There are multiple radii that are calculated. For uniform corners and thicknesses this is directly calculated by the render backend (Skia by default)

[wieslawsoltes]

Some trick using opacity mask:

<Border BorderBrush="Black" Background="Red" BorderThickness="3" Margin="10" Width="400" Height="267" CornerRadius="40" >
    <Grid>
        <Border Name="myBorder" CornerRadius="40" Background="White" Margin="1"/>
        <Rectangle Fill="Red" >
            <Rectangle.OpacityMask>
                <VisualBrush Visual="{Binding ElementName=myBorder}"/>
            </Rectangle.OpacityMask>
        </Rectangle>
    </Grid>
</Border>

[nathanAjacobs]

@wieslawsoltes I tried to use your exact XAML, but I'm getting a tiny white space near the border:

[grokys]

Problem here seems to be that although clipping to a rounded rect was added in #4081, it clips to the outer bounds of the rounded rect, not taking into account the border thickness.

UWP seems to handle this correctly, and given that we added this feature in part because UWP had it, we should match their behavior as it's more useful.

[robloo]

Just ran across this one. It makes it appear that CornerRadius doesn't work at all when authoring controls.

[maxkatz6]

CornerRadius doesn't work at all when authoring controls.

Shouldn't be the case, this issue is not about that

[JamDoggie]

Still an issue on Avalonia 0.10.12. Notice how when the ComboBoxItem gets it's color changed from transparent to a color, it overlays the parent border's corners: https://i.gyazo.com/9c8c3e28915f15ad15d59f7799d72473.mp4

[robloo]

Again, ran across this for a new control. Children should always be clipped within their parents.

[pr8x]

Any update on this :/ ? Setting CornerRadius on ContentPresenter seems to correctly clip its child, but not on Border.

[billhenn]

I'm running into this too. It would be great if you have ClipToBounds=true set, the Border's Child would be automatically clipped to be exactly inside the visible BorderThickness.

[SmRiley]

Until now (11.0.5) I have to use two borders to solve this problem

[robloo]

Note that with the BackgroundSizing support this actually became a lot easier to do.

I believe we already support any Geometry for clipping. A geometry representing the inner part of the border can be built using the GeometryBuilder. Those same geometries are needed for BackgroundSizing. With that geometry, the clipping can then be calculated and set internally. We also have the WinUI source code to see how they did this within Border already.

Avalonia/src/Avalonia.Base/Media/GeometryBuilder.cs

Lines 206 to 210 in 81d2e7d

	public static RoundedRectKeypoints CalculateRoundedCornersRectangleWinUI(
	Rect outerBounds,
	Thickness borderThickness,
	CornerRadius cornerRadius,
	BackgroundSizing sizing)

Then

Avalonia/src/Avalonia.Base/Media/GeometryBuilder.cs

Lines 35 to 37 in 81d2e7d

	public static void DrawRoundedCornersRectangle(
	StreamGeometryContext context,
	ref RoundedRectKeypoints keypoints)

I see this issue continue to pop up time and time again so will probably get to it myself eventually. However, it's probably considered a breaking change so perhaps wouldn't be allowed until 12.0 anyway.