ToggleSwitch: fix toggle on single touch tap on the knob part

[msneijders]

What does the pull request do?

Fixing issue #12519 .

What is the current behavior?

Now tapping on the knob toggles the switch twice, returning the Checked to its original state.
On desktop: if you put mouse pointer above the knob (of an already focussed ToggleSwitch!), toggling using keyboard does not work.

What is the updated/expected behavior with this PR?

• A single tap using touch device on the knob part of the ToggleSwitch should now toggle only once, instead of twice.
• On desktop, if you position the mouse pointer exactly above the knob of a focussed ToggleSwitch, the toggle now works using keyboard space to toggle.

Breaking changes

None

Fixed issues

Fixes #12519

[avaloniaui-team]

You can test this PR using the following package version. 11.0.999-cibuild0038410-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

[Mrxx99]

On desktop, if you position the mouse pointer exactly above the knob, the toggle now works using keyboard space to toggle.

Should this not only happen if the control has keyboard focus? Do other UI frameworks do this?

[msneijders]

On desktop, if you position the mouse pointer exactly above the knob, the toggle now works using keyboard space to toggle.

Should this not only happen if the control has keyboard focus? Do other UI frameworks do this?

Certainly -- on desktop if you focus the ToggleSwitch first (using tab, or mouse click) -- then you should be able to toggle it using keyboard space. But this does currently not work when your mouse pointer is exactly above the knob.

[Mrxx99]

Certainly -- on desktop if you focus the ToggleSwitch first (using tab, or mouse click) -- then you should be able to toggle it using keyboard space. But this does currently not work when your mouse pointer is exactly above the knob.

Agree, first understood it should toggle even without keyboard focus but mouse above toggle, sorry