Fix changing ItemsControl.ItemContainerTheme
#12630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One failing.
Previously only handled the case where the `ItemContainerTheme` was changing from null -> non-null. Fixes #12620
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
|
Latest PR code resolves our issue. |
emmauss
approved these changes
Aug 24, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
…eme-changes Fix changing `ItemsControl.ItemContainerTheme`
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #12620, changing an
ItemsControl'sItemContainerThemedidn't result in the change being reflected visually in some cases. The solution provided in #12620 by @timunie was almost correct but didn't correctly handle theItemContainerThemebeing set to null.Fixed these issues and added unit tests.
In doing so, I noticed that the check for
GetStyleKey(container) == itemContainerTheme.TargetTypewas incorrect as it should be possible to specify theTargetTypeusing a base class. Also added a test for this and fixed it.Fixed issues
Fixes #12620