Fix unit tests culture #13016
Merged
Fix unit tests culture #13016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Sep 25, 2023
grokys
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes some tests that are now failing after #12876 if the current culture doesn't use a dot as a decimal point.
These tests already had a
InvariantCultureFixture, which likely only work in the past with the .NET Framework (which didn't flow the current culture through the execution context, IIRC). This is now replaced by anInvariantCultureAttribute, setting the culture right before a test is run.