Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clear function to Date and Time pickers. #13082

Merged
merged 2 commits into from Oct 1, 2023

Conversation

rabbitism
Copy link
Contributor

What does the pull request do?

Add Clear function to DatePicker, TimePicker, CalendarDatePicker
Follow up of #12217
This would allow addition clear button (or default ContextFlyout MenuItem) be easily added to control template like TextBox did.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0040231-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0040272-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Oct 1, 2023
Merged via the queue into AvaloniaUI:master with commit 528eb7d Oct 1, 2023
6 checks passed
@rabbitism rabbitism deleted the feat/clear branch October 1, 2023 12:21
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 7, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Jan 17, 2024
maxkatz6 pushed a commit that referenced this pull request Jan 17, 2024
* feat: add Clear function to Date and Time pickers.

* feat: update comment wording.

---------

Co-authored-by: rabbitism <dongbin@irihi.tech>
@2114612017
Copy link

How do you use it? Are there use cases?

@maxkatz6
Copy link
Member

@2114612017 if you want to define a custom theme for the control, you can add a button to trigger this method inside now. Without any extra C# code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants