#13123 Fix ButtonSpinnerLocation in SimpleTheme #13142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
This is incorrect. The actual package version is I've tested with this package and it looks good. |
maxkatz6
approved these changes
Oct 6, 2023
Thx for pointing this out. @danwalmsley is on it. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes ButtonSpinnerLocation in SimpleTheme so that it works as expected when set to Location.Left. See #13123.
What is the current behavior?
Setting ButtonSpinner's ButtonSpinnerLocation to Location.Left has no effect when using the Simple theme.
What is the updated/expected behavior with this PR?
Setting ButtonSpinner's ButtonSpinnerLocation to Location.Left should move the spinner buttons to the left side of the content.
How was the solution implemented (if it's not obvious)?
Fixed the selector for the style that is supposed to move the spinner buttons. It specifies a
StackPanel#PART_SpinnerPanelbut the control in the template with that name is aUniformGrid, so it doesn't match anything.Checklist
I don't think any of these apply.
Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
Fixes #13123