Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ButtonSpinnerLocation does not work with Simple theme #13123

Closed
stogle opened this issue Oct 3, 2023 · 2 comments · Fixed by #13142
Closed

ButtonSpinnerLocation does not work with Simple theme #13123

stogle opened this issue Oct 3, 2023 · 2 comments · Fixed by #13142
Labels
bug help-wanted A contribution from the community would be most welcome.

Comments

@stogle
Copy link
Contributor

stogle commented Oct 3, 2023

Describe the bug

Setting ButtonSpinner's ButtonSpinnerLocation to Location.Left has no effect when using the Simple theme.

To Reproduce

Steps to reproduce the behavior:

      <ButtonSpinner Height="30" ButtonSpinnerLocation="Left">
        <TextBlock HorizontalAlignment="Center" VerticalAlignment="Center" Text="Everest"/>
      </ButtonSpinner>

Expected behavior

Setting ButtonSpinner's ButtonSpinnerLocation to Location.Left should move the spinner buttons to the left side of the content.

Environment

  • Windows 11
  • Avalonia-Version: 11.0.x

Additional context

The selector in ButtonSpinner.xaml is incorrect. Instead of

<Style Selector="^ /template/ StackPanel#PART_SpinnerPanel">

it should be

      <Style Selector="^ /template/ UniformGrid#PART_SpinnerPanel">
@stogle stogle added the bug label Oct 3, 2023
@maxkatz6 maxkatz6 added the help-wanted A contribution from the community would be most welcome. label Oct 3, 2023
@timunie
Copy link
Contributor

timunie commented Oct 4, 2023

@stogle can you file a PR to solve this? Would be appreciated.

@stogle
Copy link
Contributor Author

stogle commented Oct 5, 2023

@timunie I created #13142 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help-wanted A contribution from the community would be most welcome.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants