Fix DataGrid IList editing issue #13845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
area-datagrid
backport-candidate-11.0.x
|
Specifically that issue was caused by this property always returning Avalonia/src/Avalonia.Controls.DataGrid/DataGridDataConnection.cs Lines 40 to 53 in a028347 |
|
You can test this PR using the following package version. |
This was referenced Dec 11, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Jan 17, 2024
* Implement basic writeable IList on DataGridCollectionView hopefully it won't break anything else * Make preference over DataGridCollectionView in DataGridDataConnection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes 11.0.6/master issue regressed by #13313
Personally, I would consider reverting previous PR, as DataGridCollectionView isn't really intended to be used outside of the DataGrid (...duh).
But this PR attempts to fix current behavior, hopefully without breaking anything else.
Fixed issues
Fixes #13843