Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ShowNoActivate in Win32NativeControlHost. #13966

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

grokys
Copy link
Member

@grokys grokys commented Dec 15, 2023

What does the pull request do?

Fixes a customer issue:

In our product we only attach the host when our renderer component has finished loading, which can take quite a while. This means that when loading completes, the renderer window unexpectedly activates and disrupts whatever the user was doing at the time.

This prevents a NativeControlHost sealing focus on win32. As far as I'm aware no other controls steal focus/activation when they're shown so hopefully makes sense to do this.

This prevents a `NativeControlHost` sealing focus on win32.
@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 15, 2023
@grokys grokys requested a review from kekekeks December 15, 2023 13:13
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0042944-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys added this pull request to the merge queue Dec 15, 2023
Merged via the queue into master with commit 79b79bb Dec 15, 2023
7 checks passed
@grokys grokys deleted the fixes/win32nativecontrolhost-activate branch December 15, 2023 15:20
grokys added a commit that referenced this pull request Dec 15, 2023
This prevents a `NativeControlHost` sealing focus on win32.
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Jan 17, 2024
maxkatz6 pushed a commit that referenced this pull request Jan 17, 2024
This prevents a `NativeControlHost` sealing focus on win32.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants