Fix DBus Exception on window close #13997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Dec 19, 2023
maxkatz6
added
the
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Only disconnect from ibus when connected * Catch exception on Destroy when ime context is successfully created but doesn't actually exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix an issue when Avalonia is instructed to use ibus as IME but ibus is not available, e.g. by settings the env var
GTK_IM_MODULE=ibusThe IM context is (somehow) successfully created but doesn't actually exist, so naturally Destroy fails when it's called on Dispose.
What is the current behavior?
The app crashes
What is the updated/expected behavior with this PR?
The exception is caught.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
#13863