Do not crash on IsCurrent checks #14089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
os-windows
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Jan 3, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
EglContext.IsCurrent currently throws an exception, if context was already lost. This behavior doesn't seem to be replicated in other IGlContext implementations, and causes issues, when surface is being disposed after context was disposed.
After this change, context.EnsureCurrent will still crash with PlatformGraphicsContextLostException, but rendering backend can handle that exception properly.
Fixed issues
Fixes #13919
Fixes #14077