Port DragMove logic from WPF #14186
Merged
Port DragMove logic from WPF #14186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kekekeks
approved these changes
Jan 12, 2024
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
approved these changes
Jan 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Port DragMove logic from WPF to fix missing PointerReleased event on drag out. * remove WindowState.Normal check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic seems to work better than sending WM_NCLBUTTONDOWN. It doesn't seem to block button events and it's what WPF uses as well so yeah.
cc @kekekeks @emmauss