Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inlines clear handling #14247

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jan 17, 2024

What does the pull request do?

Reset VisualChildren and _textRun on invalidation

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes: #13891

@Gillibald Gillibald added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Jan 17, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044048-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 2ecfbb9 into AvaloniaUI:master Jan 27, 2024
4 of 6 checks passed
maxkatz6 pushed a commit that referenced this pull request Feb 8, 2024
* Make sure to clean up VisualChildren and created text runs when the TextLayout is invalidate

* Remove localized comment

---------

Co-authored-by: Tim <47110241+timunie@users.noreply.github.com>
#Conflicts:
#	src/Avalonia.Controls/TextBlock.cs
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextBlock.Inlines.Clear() no work
4 participants