Fix Previewer crash from Refit reflection (#14282) #14301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
mayka-mack
force-pushed
the
fixes/designer-crash
branch
from
14c753b
to
471642c
Compare
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
approved these changes
Jan 22, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Due to its use of reflection, invoking Refit causes the Previewer to crash, since
Assembly.LoadFiledoesn't make the app's assembly available for reflection within the context of the Previewer. Therefore, Refit's reflection-based generator fails. See reactiveui/refit#1476 for more details.What is the current behavior?
Using Refit causes the Previewer to crash.
What is the updated/expected behavior with this PR?
The app assembly is now available for reflection within the context of the Previewer, so the Previewer will not crash.
How was the solution implemented (if it's not obvious)?
Changes the Avalonia previewer's
Assembly.LoadFileusage toAssembly.LoadFrom.Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #14282