Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previewer sometimes not finding deps file #14552

Merged
merged 1 commit into from Feb 9, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Feb 9, 2024

Fixes #14543

@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Feb 9, 2024
@maxkatz6 maxkatz6 merged commit f60321e into master Feb 9, 2024
2 of 6 checks passed
@maxkatz6 maxkatz6 deleted the fix-previewer-not-finding-deps-file branch February 9, 2024 02:08
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Feb 9, 2024
@jp2masa
Copy link
Contributor

jp2masa commented Feb 9, 2024

I'm curious about this fix. When is the .deps.json file name different from the assembly file name?

I checked workgroupengineering's repro and didn't understand...

@maxkatz6
Copy link
Member Author

maxkatz6 commented Feb 9, 2024

@jp2masa when previewer compiles XAML targeting non-entry assembly, but assembly where previewing XAML file is.

Although, while by itself it sounds like a valid use case, it shouldn't really happen with current previewer infrastructure. Especially since we require assembly with BuildAvaloniaApp startup method. And it actually works in 11.0.8 too, but XAML is still compiled with another assembly.
It's something to investigate later though, for now I am keeping this hack, as it can be considered so.

There only were two another PRs related to the previewer #14287 and #14301, each fixing other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avalonia 11.0.8 break Previewer when using Interaction.Behaviors
2 participants