WIP: Use ItemsRepeater as base for ItemsPresenter #3388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft/microsoft-ui-xaml#1425 describes a bug which causes scrolling to break with `ItemsRepeater`. This is a temporary fix that seems to work around it - not sure if it's the correct fix so when the WinUI issue is fixed, undo this change and port the change from there if it's different.
Move `ContainerFromIndex` and `IndexFromContainer` from `SelectingItemsControl` to `ItemsControl` and make them public.
This was referenced Feb 3, 2020
1 task
|
Closing this as it's out-of-date, will open a new PR to implement this soon. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Work-in-progress in getting
ItemsRepeaterto be the base forItemsPresenter.