Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NonVirtualizingStackLayout. #3771

Merged
merged 3 commits into from
Apr 11, 2020
Merged

Added NonVirtualizingStackLayout. #3771

merged 3 commits into from
Apr 11, 2020

Conversation

grokys
Copy link
Member

@grokys grokys commented Apr 10, 2020

What does the pull request do?

Adds our first non-virtualizing attached layout: NonVirtualizingStackLayout. This isn't present in WinUI so was implemented from scratch. Required fixing/implementing a bunch of infrastructure around non-virtualizing layouts.

This will be needed as part of #3388

Checklist

  • Added unit tests (if possible)?

@grokys
Added NonVirtualizingStackLayout.
faec3ae 
Required fixing/implementing a bunch of infrastructure around non-virtualizing layouts.
@grokys grokys requested a review from a team April 10, 2020 07:19
@MarchingCube
Copy link
Collaborator

How does this relate to normal StackPanel and VirtualizingStackPanel? Will we keep both solutions or this is supposed to replace current containers as well?

MarchingCube
MarchingCube approved these changes Apr 11, 2020
View reviewed changes
Copy link
Collaborator

@MarchingCube MarchingCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grokys
Copy link
Member Author

grokys commented Apr 11, 2020

How does this relate to normal StackPanel and VirtualizingStackPanel? Will we keep both solutions or this is supposed to replace current containers as well?

At the moment this is just for ItemsRepeater in cases where you don't want virtualization. WinUI also adds a LayoutPanel which is a Panel that can use attached layouts, but that's not been ported yet.

@grokys grokys merged commit 07c7834 into master Apr 11, 2020
@grokys grokys deleted the feature/attachedlayout-non-virtualizing branch April 11, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarchingCube MarchingCube MarchingCube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grokys @MarchingCube