Feature/fluent progress bar #4074
Conversation
danwalmsley
force-pushed
the
feature/fluent-progress-bar
branch
from
8e3d487
to
4554a3d
Compare
src/Avalonia.Controls/ProgressBar.cs
Outdated
| @@ -20,17 +20,47 @@ public class ProgressBar : RangeBase | |||
| public static readonly StyledProperty<Orientation> OrientationProperty = | |||
| AvaloniaProperty.Register<ProgressBar, Orientation>(nameof(Orientation), Orientation.Horizontal); | |||
|
|
|||
| private static readonly DirectProperty<ProgressBar, double> IndeterminateStartingOffsetProperty = | |||
| public static readonly DirectProperty<ProgressBar, double> ContainerAnimationStartPositionProperty = | |||
There was a problem hiding this comment.
Those new props are from UWP's ProgressBarTemplateSettings, separated from ProgressBar class with point to hide template properties. Also they are get-only.
As for me It's fine to move them to ProgressBar.cs class, but should we?
There was a problem hiding this comment.
Sorry im not familiar in that part of UWP, but idk what's the point of that primitive though? If isnt gonna be used by anything else other than ProgressBar then i dont think it needs to be split from it..
There was a problem hiding this comment.
I think it is just to move template specific props out. It's common pattern for some controls in UWP.
jmacato
force-pushed
the
feature/fluent-progress-bar
branch
from
87e1add
to
ef2a96c
Compare
# Conflicts: # samples/ControlCatalog/App.xaml # samples/ControlCatalog/MainView.xaml.cs # samples/ControlCatalog/MainWindow.xaml
…ress-bar # Conflicts: # src/Avalonia.Themes.Fluent/Accents/FluentControlResourcesDark.xaml
|
make template properties class and property private? @maxkatz6 |
|
@jmacato need you to fix the default theme progress bar... as this breaks the indeterminate version. |
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Fixed issues