Fluent ScrollBar/ScrollViewer #4119
Conversation
MarchingCube
changed the title
| /// <summary> | ||
| /// Defines the <see cref="IsExpandedProperty"/> property. | ||
| /// </summary> | ||
| public static readonly DirectProperty<ScrollViewer, bool> IsExpandedProperty = |
There was a problem hiding this comment.
Do we need IsExpanded property?
I am not sure, if it is useful anywhere except template.
There was a problem hiding this comment.
I think this will be used when we detect the scrolling is via touch and set this to false... to prevent expansion? @MarchingCube
There was a problem hiding this comment.
Currently it is only used in the template, I've added it mostly to keep API similar between ScrollBar and ScrollViewer. Also might be useful if somebody wants to bind to it. Other option would be a pseudoclass which is basically the same but not public.
| @@ -193,6 +250,68 @@ protected override void OnApplyTemplate(TemplateAppliedEventArgs e) | |||
| } | |||
| } | |||
|
|
|||
| private void InvokeAfterDelay(Action handler, TimeSpan delay) | |||
There was a problem hiding this comment.
interesting, i had thought we could use transition delay, etc.
There was a problem hiding this comment.
Transitions have several issues right now that make use hard:
- you can't bind any properties on a transition.
- in this case we have different delay when collapsing and when expanding. CSS way of solving that is to have two sets of transitions, one that matches non-expanded and one that matches the expanded one. But due to bugs in transition handling replacing transitions cause neutral values to be lost.
|
nice work, one small thing, I did not test it and maybe I'm wrong but from animation at the first post, it looks like that hit zones in collapsed mode are too thin and should be a bit expanded :) |
Hit zones are the same for both collapsed and expanded modes. So you don't need to be pixel perfect and just having the cursor in the vicinity will expand it.
|
|
WinUI also hides scrollbar completely, if scrollviewer is not focused (or its child) and it wasn't expanded before. On scrollviewer pointer over it immediately shows again. Not sure, if it is important, but I just found it while comparing this one with WinUI. |
|
Good job by the way, it looks and feels great) |
What does the pull request do?
Ported
ScrollBarandScrollViewerfrom WinUI.What is the current behavior?
Well, launch control catalog and see for yourself :)
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Due to sheer amount of states and issues with transitions (can't replace transitions and keep neutral values) I had to implement delays using timers. Hopefully when we fix transitions we could just simplify this a bit.
Also I am not so sure about how to let XAML configure delays for expand/collapse. I don't want to expose yet another property just for it.
I am using a property for expanded state since it is a bit easier to bind it and check for changes (and
ScrollViewerneeds to know if anyScrollBaris expanded, WinUI has weird setup to workaround it as well so I think our setup is a bit cleaner atm).Checklist
Breaking changes
Fixed issues