Features zerowarnings: Changes which alter code and could affect functionality in the base library

samples/interop/NativeEmbedSample/NativeEmbedSample.csproj

@@ -5,6 +5,7 @@
     <TargetFramework>netcoreapp2.0</TargetFramework>
     <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <SignAssembly>false</SignAssembly>
   </PropertyGroup>
 
   <ItemGroup>

src/Android/Avalonia.Android/Platform/SkiaPlatform/InvalidationAwareSurfaceView.cs

@@ -43,11 +43,13 @@ public override void Invalidate()
             }
         }
 
+        [Obsolete]
         public override void Invalidate(global::Android.Graphics.Rect dirty)
         {
             Invalidate();
         }
 
+        [Obsolete]
         public override void Invalidate(int l, int t, int r, int b)
         {
             Invalidate();

src/Android/Avalonia.Android/Platform/Specific/Helpers/AndroidTouchEventsHelper.cs

@@ -86,7 +86,9 @@ public AndroidTouchEventsHelper(TView view, Func<IInputRoot> getInputRoot, Func<
                         mouseEventType.Value, _point, RawInputModifiers.LeftMouseButton);
                     _view.Input(mouseEvent);
 
+#pragma warning disable CS0618 // Type or member is obsolete
                     if (e.Action == MotionEventActions.Move && mouseDevice.Captured == null)
+#pragma warning restore CS0618 // Type or member is obsolete
                     {
                         if (_lastTouchMovePoint != null)
                         {

src/Avalonia.Base/Data/BindingValue.cs

@@ -246,7 +246,9 @@ public static BindingValue<T> FromUntyped(object? value)
                 UnsetValueType _ => Unset,
                 DoNothingType _ => DoNothing,
                 BindingNotification n => n.ToBindingValue().Cast<T>(),
+#pragma warning disable CS8601
                 _ => new BindingValue<T>((T)value)
+#pragma warning restore CS8601
             };
         }
 

src/Avalonia.Base/Data/Converters/MethodToCommandConverter.cs

@@ -1,12 +1,13 @@
 using System;
 using System.ComponentModel;
+using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
 using System.Linq.Expressions;
 using System.Reflection;
 using System.Windows.Input;
 using Avalonia.Utilities;
-
+#nullable enable
 namespace Avalonia.Data.Converters
 {
     class MethodToCommandConverter : ICommand
@@ -18,11 +19,11 @@ class MethodToCommandConverter : ICommand
             .GetProperty(nameof(CultureInfo.CurrentCulture), BindingFlags.Public | BindingFlags.Static);
         readonly Func<object, bool> canExecute;
         readonly Action<object> execute;
-        readonly WeakPropertyChangedProxy weakPropertyChanged;
-        readonly PropertyChangedEventHandler propertyChangedEventHandler;
-        readonly string[] dependencyProperties;
+        readonly WeakPropertyChangedProxy? weakPropertyChanged;
+        readonly PropertyChangedEventHandler? propertyChangedEventHandler;
+        readonly string[]? dependencyProperties;
 
-        public MethodToCommandConverter(Delegate action)
+        public MethodToCommandConverter([DisallowNull] Delegate action)
         {
             var target = action.Target;
             var canExecuteMethodName = "Can" + action.Method.Name;
@@ -74,7 +75,7 @@ void OnPropertyChanged(object sender, PropertyChangedEventArgs args)
         }
 
 #pragma warning disable 0067
-        public event EventHandler CanExecuteChanged;
+        public event EventHandler? CanExecuteChanged;
 #pragma warning restore 0067
 
         public bool CanExecute(object parameter) => canExecute(parameter);
@@ -140,7 +141,7 @@ void OnPropertyChanged(object sender, PropertyChangedEventArgs args)
                     );
 
             }
-            Action<object> action = null;
+            Action<object> action;
             try
             {
                 action = Expression
@@ -173,6 +174,7 @@ void OnPropertyChanged(object sender, PropertyChangedEventArgs args)
         private static Expression? ConvertTarget(object? target, MethodInfo method) =>
             target is null ? null : Expression.Convert(Expression.Constant(target), method.DeclaringType);
 
+#nullable disable
         internal class WeakPropertyChangedProxy
         {
             readonly WeakReference<PropertyChangedEventHandler> _listener = new WeakReference<PropertyChangedEventHandler>(null);
@@ -215,5 +217,6 @@ void OnPropertyChanged(object sender, PropertyChangedEventArgs e)
             }
 
         }
+#nullable restore
     }
 }

src/Avalonia.Base/ValueStore.cs

@@ -37,7 +37,7 @@ public bool IsAnimating(AvaloniaProperty property)
         {
             if (_values.TryGetValue(property, out var slot))
             {
-                return slot.Priority < BindingPriority.LocalValue;
+                return slot?.Priority < BindingPriority.LocalValue;
             }
 
             return false;
@@ -47,7 +47,7 @@ public bool IsSet(AvaloniaProperty property)
         {
             if (_values.TryGetValue(property, out var slot))
             {
-                return slot.GetValue().HasValue;
+                return slot?.GetValue().HasValue == true;
             }
 
             return false;
@@ -58,7 +58,7 @@ public bool IsSet(AvaloniaProperty property)
             BindingPriority maxPriority,
             out T value)
         {
-            if (_values.TryGetValue(property, out var slot))
+            if (_values.TryGetValue(property, out var slot) && slot != null)
             {
                 var v = ((IValue<T>)slot).GetValue(maxPriority);
 
@@ -82,7 +82,7 @@ public bool IsSet(AvaloniaProperty property)
 
             IDisposable? result = null;
 
-            if (_values.TryGetValue(property, out var slot))
+            if (_values.TryGetValue(property, out var slot) && slot != null)
             {
                 result = SetExisting(slot, property, value, priority);
             }
@@ -119,7 +119,7 @@ public bool IsSet(AvaloniaProperty property)
             IObservable<BindingValue<T>> source,
             BindingPriority priority)
         {
-            if (_values.TryGetValue(property, out var slot))
+            if (_values.TryGetValue(property, out var slot) && slot != null)
             {
                 return BindExisting(slot, property, source, priority);
             }
@@ -183,7 +183,7 @@ public void CoerceValue<T>(StyledPropertyBase<T> property)
 
         public Diagnostics.AvaloniaPropertyValue? GetDiagnostic(AvaloniaProperty property)
         {
-            if (_values.TryGetValue(property, out var slot))
+            if (_values.TryGetValue(property, out var slot) && slot != null)
             {
                 var slotValue = slot.GetValue();
                 return new Diagnostics.AvaloniaPropertyValue(

src/Avalonia.Controls.DataGrid/Collections/DataGridGroupDescription.cs

@@ -58,7 +58,6 @@ public class DataGridPathGroupDescription : DataGridGroupDescription
     {
         private string _propertyPath;
         private Type _propertyType;
-        private IValueConverter _valueConverter;
         private StringComparison _stringComparison = StringComparison.Ordinal;
 
         public DataGridPathGroupDescription(string propertyPath)
@@ -83,8 +82,8 @@ object GetKey(object o)
             if (key == null)
                 key = item;
 
-            if (_valueConverter != null)
-                key = _valueConverter.Convert(key, typeof(object), level, culture);
+            if (ValueConverter != null)
+                key = ValueConverter.Convert(key, typeof(object), level, culture);
 
             return key;
         }
@@ -99,6 +98,8 @@ public override bool KeysMatch(object groupKey, object itemKey)
         }
         public override string PropertyName => _propertyPath;
 
+        public IValueConverter ValueConverter { get; set; }
+
         private Type GetPropertyType(object o)
         {
             return o.GetType().GetNestedPropertyType(_propertyPath);

src/Avalonia.Controls.DataGrid/DataGrid.cs

@@ -74,8 +74,6 @@ public partial class DataGrid : TemplatedControl
         internal const double DATAGRID_defaultRowGroupSublevelIndent = 20;
         private const double DATAGRID_defaultMinColumnWidth = 20;
         private const double DATAGRID_defaultMaxColumnWidth = double.PositiveInfinity;
-
-        private List<Exception> _validationErrors;
         private List<Exception> _bindingValidationErrors;
         private IDisposable _validationSubscription;
 
@@ -102,7 +100,6 @@ public partial class DataGrid : TemplatedControl
         private bool _areHandlersSuspended;
         private bool _autoSizingColumns;
         private IndexToValueTable<bool> _collapsedSlotsTable;
-        private DataGridCellCoordinates _currentCellCoordinates;
         private Control _clickedElement;
 
         // used to store the current column during a Reset
@@ -141,7 +138,6 @@ public partial class DataGrid : TemplatedControl
         private DataGridSelectedItemsCollection _selectedItems;
         private bool _temporarilyResetCurrentCell;
         private object _uneditedValue; // Represents the original current cell value at the time it enters editing mode.
-        private ICellEditBinding _currentCellEditBinding;
 
         // An approximation of the sum of the heights in pixels of the scrolling rows preceding
         // the first displayed scrolling row.  Since the scrolled off rows are discarded, the grid

src/Avalonia.Controls.DataGrid/Utils/CellEditBinding.cs

@@ -57,7 +57,6 @@ class SubjectWrapper : LightweightObservableBase<object>, ISubject<object>, IDis
             private IDisposable _subscription;
             private object _controlValue;
             private bool _isControlValueSet = false;
-            private bool _settingSourceValue = false;
 
             public SubjectWrapper(ISubject<object> bindingSourceSubject, CellEditBinding editBinding)
             {
@@ -67,11 +66,7 @@ public SubjectWrapper(ISubject<object> bindingSourceSubject, CellEditBinding edi
 
             private void SetSourceValue(object value)
             {
-                _settingSourceValue = true;
-
                 _sourceSubject.OnNext(value);
-
-                _settingSourceValue = false;
             }
             private void SetControlValue(object value)
             {
@@ -157,4 +152,4 @@ public void CommitEdit()
             }
         }
     }
-}
+}

src/Avalonia.Controls/ApiCompatBaseline.txt

@@ -0,0 +1,4 @@
+Compat issues with assembly Avalonia.Controls:
+MembersMustExist : Member 'public void Avalonia.Controls.Platform.InternalPlatformThreadingInterface.add_Tick(System.Action<System.TimeSpan>)' does not exist in the implementation but it does exist in the contract.
+MembersMustExist : Member 'public void Avalonia.Controls.Platform.InternalPlatformThreadingInterface.remove_Tick(System.Action<System.TimeSpan>)' does not exist in the implementation but it does exist in the contract.
+Total Issues: 2

src/Avalonia.Controls/Application.cs

@@ -155,7 +155,7 @@ public IResourceDictionary Resources
 
         /// <inheritdoc/>
         bool IResourceNode.HasResources => (_resources?.HasResources ?? false) ||
-            (((IResourceNode?)_styles)?.HasResources ?? false);
+            ((_styles as IResourceNode)?.HasResources ?? false);
 
         /// <summary>
         /// Gets the styling parent of the application, which is null.

src/Avalonia.Controls/Border.cs

@@ -8,7 +8,9 @@ namespace Avalonia.Controls
     /// <summary>
     /// A control which decorates a child with a border and background.
     /// </summary>
+#pragma warning disable CS0618 // Type or member is obsolete
     public partial class Border : Decorator, IVisualWithRoundRectClip
+#pragma warning restore CS0618 // Type or member is obsolete
     {
         /// <summary>
         /// Defines the <see cref="Background"/> property.

src/Avalonia.Controls/DrawingPresenter.cs

@@ -6,6 +6,8 @@
 namespace Avalonia.Controls
 {
     [Obsolete("Use Image control with DrawingImage source")]
+    [System.ComponentModel.Browsable(false)]
+    [System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
     public class DrawingPresenter : Control
     {
         static DrawingPresenter()

src/Avalonia.Controls/Grid.cs

@@ -978,6 +978,7 @@ private void ApplyCachedMinSizes(double[] minSizes, bool isRows)
         /// width is not registered in columns.</param>
         /// <param name="forceInfinityV">Passed through to MeasureCell.
         /// When "true" cells' desired height is not registered in rows.</param>
+        /// <param name="hasDesiredSizeUChanged">When "true" desidere size is changed.</param>
         private void MeasureCellsGroup(
             int cellsHead,
             Size referenceSize,

src/Avalonia.Controls/Menu.cs

@@ -17,8 +17,6 @@ public class Menu : MenuBase, IMainMenu
         private static readonly ITemplate<IPanel> DefaultPanel =
             new FuncTemplate<IPanel>(() => new StackPanel { Orientation = Orientation.Horizontal });
 
-        private LightDismissOverlayLayer? _overlay;
-
         /// <summary>
         /// Initializes a new instance of the <see cref="Menu"/> class.
         /// </summary>

src/Avalonia.Controls/Platform/InternalPlatformThreadingInterface.cs

@@ -1,10 +1,7 @@
 using System;
-using System.Collections.Generic;
 using System.Runtime.InteropServices;
 using System.Threading;
-using System.Threading.Tasks;
 using Avalonia.Platform;
-using Avalonia.Rendering;
 using Avalonia.Threading;
 
 namespace Avalonia.Controls.Platform
@@ -83,7 +80,5 @@ public void Signal(DispatcherPriority prio)
 
         public bool CurrentThreadIsLoopThread => TlsCurrentThreadIsLoopThread;
         public event Action<DispatcherPriority?> Signaled;
-        public event Action<TimeSpan> Tick;
-
     }
 }

src/Avalonia.Controls/Primitives/Popup.cs

@@ -87,8 +87,8 @@ public class Popup : Control, IVisualTreeHost
         public static readonly StyledProperty<bool> OverlayDismissEventPassThroughProperty =
             AvaloniaProperty.Register<Popup, bool>(nameof(OverlayDismissEventPassThrough));
 
-        public static readonly DirectProperty<Popup, IInputElement> OverlayInputPassThroughElementProperty =
-            AvaloniaProperty.RegisterDirect<Popup, IInputElement>(
+        public static readonly DirectProperty<Popup, IInputElement?> OverlayInputPassThroughElementProperty =
+            AvaloniaProperty.RegisterDirect<Popup, IInputElement?>(
                 nameof(OverlayInputPassThroughElement),
                 o => o.OverlayInputPassThroughElement,
                 (o, v) => o.OverlayInputPassThroughElement = v);
@@ -132,7 +132,7 @@ public class Popup : Control, IVisualTreeHost
         private bool _isOpen;
         private bool _ignoreIsOpenChanged;
         private PopupOpenState? _openState;
-        private IInputElement _overlayInputPassThroughElement;
+        private IInputElement? _overlayInputPassThroughElement;
 
         /// <summary>
         /// Initializes static members of the <see cref="Popup"/> class.
@@ -299,7 +299,7 @@ public bool OverlayDismissEventPassThrough
         /// Gets or sets an element that should receive pointer input events even when underneath
         /// the popup's overlay.
         /// </summary>
-        public IInputElement OverlayInputPassThroughElement
+        public IInputElement? OverlayInputPassThroughElement
         {
             get => _overlayInputPassThroughElement;
             set => SetAndRaise(OverlayInputPassThroughElementProperty, ref _overlayInputPassThroughElement, value);

src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs

@@ -448,8 +448,10 @@ static class PopupPositionerExtensions
             PopupPositionerConstraintAdjustment constraintAdjustment, Rect? rect)
         {
             // We need a better way for tracking the last pointer position
+#pragma warning disable CS0618 // Type or member is obsolete
             var pointer = topLevel.PointToClient(topLevel.PlatformImpl.MouseDevice.Position);
-
+#pragma warning restore CS0618 // Type or member is obsolete
+
             positionerParameters.Offset = offset;
             positionerParameters.ConstraintAdjustment = constraintAdjustment;
             if (placement == PlacementMode.Pointer)

src/Avalonia.Controls/Primitives/TemplatedControl.cs

@@ -265,7 +265,9 @@ public sealed override void ApplyTemplate()
 
                     var e = new TemplateAppliedEventArgs(nameScope);
                     OnApplyTemplate(e);
+#pragma warning disable CS0618 // Type or member is obsolete
                     OnTemplateApplied(e);
+#pragma warning restore CS0618 // Type or member is obsolete
                     RaiseEvent(e);
                 }
 
@@ -333,6 +335,8 @@ protected virtual void OnApplyTemplate(TemplateAppliedEventArgs e)
         /// </summary>
         /// <param name="e">The event args.</param>
         [Obsolete("Use OnApplyTemplate")]
+        [System.ComponentModel.Browsable(false)]
+        [System.ComponentModel.EditorBrowsable(System.ComponentModel.EditorBrowsableState.Never)]
         protected virtual void OnTemplateApplied(TemplateAppliedEventArgs e)
         {
         }

src/Avalonia.Controls/ProgressBar.cs

@@ -217,8 +217,10 @@ private void UpdateIndicator(Size bounds)
                     TemplateProperties.Container2AnimationEndPosition = barIndicatorWidth2 * 1.66; // Position at 166%
 
                     // Remove these properties when we switch to fluent as default and removed the old one.
+#pragma warning disable CS0618 // Type or member is obsolete
                     IndeterminateStartingOffset = -dim;
                     IndeterminateEndingOffset = dim;
+#pragma warning restore CS0618 // Type or member is obsolete
 
                     var padding = Padding;
                     var rectangle = new RectangleGeometry(

src/Avalonia.Controls/Remote/RemoteServer.cs

@@ -1,7 +1,5 @@
-using System;
-using Avalonia.Controls.Embedding;
+using Avalonia.Controls.Embedding;
 using Avalonia.Controls.Remote.Server;
-using Avalonia.Platform;
 using Avalonia.Remote.Protocol;
 
 namespace Avalonia.Controls.Remote
@@ -15,9 +13,6 @@ class EmbeddableRemoteServerTopLevelImpl : RemoteServerTopLevelImpl
             public EmbeddableRemoteServerTopLevelImpl(IAvaloniaRemoteTransportConnection transport) : base(transport)
             {
             }
-#pragma warning disable 67
-            public Action LostFocus { get; set; }
-
         }
 
         public RemoteServer(IAvaloniaRemoteTransportConnection transport)