-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CefNet.Avalonia Compat #5763
Conversation
@kekekeks are we OK exposing |
Looks like only the Win32 platform uses a handle and the rest sets the property to On Win32 just cast to |
It also seems to have influenced macOS and Linux https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.X11/X11CursorFactory.cs#L72 Mobile platforms may not need |
All platform handles should be exposed as IPlatformHandle. In some cases platform handles might be non-representable as a plain IntPtr without additional info. For Win32 we can use |
…ests.Data.BindingTests_Method.Binding_Method_To_Command_Collected [FAIL]
What does the pull request do?
ca408e5 Breaking the compatibility
CefNet.Avalonia required cursor handle.
https://github.com/CefNet/CefNet/blob/master/CefNet.Avalonia/Internal/CursorInteropHelper.cs#L18
What is the current behavior?