-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ICustomHitTest #5923
Merged
Merged
Fix ICustomHitTest #5923
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
690a5dd
HitTestEnumerator: Account for ICustomSimpleHitTest
mat1jaczyyy ad14ece
HitTestEnumerator: FilterAndClip don't transform point for ICustomHit…
mat1jaczyyy 5f4a338
ICustomHitTest renderer tests
mat1jaczyyy 98e773a
ICustomHitTest: Remove comment, expanding the hittable area is possible
mat1jaczyyy 8c25735
ICustomSimpleHitTest: Clarify with XML comment that point is in globa…
mat1jaczyyy d23041b
Merge branch 'master' into fixes/5879-icustomhittest
MarchingCube 81e7034
Merge branch 'master' into fixes/5879-icustomhittest
maxkatz6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
tests/Avalonia.Visuals.UnitTests/Rendering/CustomHitTestBorder.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
using Avalonia.Controls; | ||
using Avalonia.Media; | ||
using Avalonia.Rendering; | ||
|
||
namespace Avalonia.Visuals.UnitTests.Rendering | ||
{ | ||
internal class CustomHitTestBorder : Border, ICustomHitTest | ||
{ | ||
public bool HitTest(Point point) | ||
{ | ||
// Move hit testing window halfway to the left | ||
return Bounds | ||
.WithX(Bounds.X - Bounds.Width / 2) | ||
.Contains(point); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about ICustomSimpleHitTest ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch