Fix ICustomHitTest #5923
Merged
Fix ICustomHitTest #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -311,8 +312,7 @@ private bool FilterAndClip(IVisualNode node, ref Rect? clip) | |||
|
|
|||
| if (!clipped && node.Visual is ICustomHitTest custom) | |||
There was a problem hiding this comment.
What about ICustomSimpleHitTest ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
ICustomHitTest wasn't being handled correctly when using deferred renderer. Immediate renderer functions as intended.
What is the current behavior?
Deferred renderer passes incorrectly translated points for clipping, and for actual hit testing doesn't test at all.
What is the updated/expected behavior with this PR?
A repro is provided in #5879. Deferred renderer now passes non-translated points and does actual hit testing. On an slightly less related note, upon inspection it's possible to expand the hit window using this interface, so I've removed an old comment which claimed it was not possible. This is intended behavior.
Checklist
Breaking changes
People using deferred renderer will now have non-translated points passed to
HitTest.Fixed issues
Fixes #5879