-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom hit testing #5968
Fix custom hit testing #5968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not sure this is right, and I've been unable to test it: the description says "Custom hit testing when custom title bar is used not working." but when I run ControlCatalog and go to "Dialogs -> Decorated Window" the custom title bar seems to work fine?
First of all how do I repro the problem in order to verify the fix?
@grokys repro:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, reverted the TransformedBounds
change as I've checked and this PR fixes custom title bar hit-testing on the deferred renderer without it and it was already broken on the immediate renderer before #5923, so makes no difference there either.
* Fix custom hit testing * Use ICustomHitTest as it's intended to be used in defered renderer Co-authored-by: Dan Walmsley <dan@walms.co.uk> Co-authored-by: Steven Kirk <grokys@users.noreply.github.com> Co-authored-by: Steven Kirk <grokys@gmail.com>
What does the pull request do?
Fixes custom hit-testing broken in #5923
What is the current behavior?
Custom hit testing when custom title bar is used not working.
What is the updated/expected behavior with this PR?
Fixes custom hit-testing.
How was the solution implemented (if it's not obvious)?
Check for correct interface.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues