Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Fix child window order with multiple child windows #8880

Merged
merged 5 commits into from
Sep 8, 2022

Commits on Sep 1, 2022

  1. Display window order in integration test app.

    The previous method of relying on the order of windows returned by appium to determine window z-order proved not to be reliable. Instead use p/invoke to read `NSWindow.orderedIndex` on a timer and display it in a text box in the `ShowWindowtest` window.
    
    This commit doesn't update the tests to use this new info though.
    grokys committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    0cc0443 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d1b6522 View commit details
    Browse the repository at this point in the history
  3. Add failing test for #8878.

    And update the tests to use the value of `NSWindow.orderedIndex` exposed in 0cc0443 instead of relying on appium to give us a z-ordered list of windows.
    grokys committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    1c4a994 View commit details
    Browse the repository at this point in the history
  4. Don't bring old parent window to front.

    When a window is closed, its parent window is set to null, which caused this code to run. This line caused the parent window to be brought to front, and should have also caused any other child windows to be brought to front, but it seems OSX ignored those requests, causing #8878.
    
    Simply don't bring the parent window to the front when a child window is closed. I couldn't work out why this code was necessary anyway, and all integration tests still pass.
    
    Fixes #8878.
    grokys committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    b83b795 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    72fa09f View commit details
    Browse the repository at this point in the history