Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP-923: Disable Oshi in surefire tests #119

Merged
merged 2 commits into from
Dec 22, 2021
Merged

TP-923: Disable Oshi in surefire tests #119

merged 2 commits into from
Dec 22, 2021

Conversation

ath0s
Copy link
Contributor

@ath0s ath0s commented Dec 21, 2021

No description provided.

pativa
pativa approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@pativa pativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we need to make this change in more branches, or is it enough with the master branch?

@ath0s
Copy link
Contributor Author

ath0s commented Dec 21, 2021

Nice! Do we need to make this change in more branches, or is it enough with the master branch?

I'm thinking the master branch is enough for the time being.

Bjornelmers
Bjornelmers reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@Bjornelmers Bjornelmers left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future references it could be a good idea to leave a comment above the property about why we do this. At least it would not be obvious at all for me 😅

Bjornelmers
Bjornelmers approved these changes Dec 22, 2021
View reviewed changes
Copy link
Contributor

@Bjornelmers Bjornelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@ath0s ath0s merged commit 02492aa into master Dec 22, 2021
@ath0s ath0s deleted the TP-923-disable-oshi-for-tests branch December 22, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjornelmers Bjornelmers Bjornelmers approved these changes

@pativa pativa pativa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ath0s @Bjornelmers @pativa