Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fetching bundle file sizes for build bundles #152

Merged
merged 6 commits into from
Dec 6, 2021

Conversation

birwin93
Copy link
Contributor

  • Creates BuildBundles and BuildBundleFileSizes models
  • Adds endpoint to fetch BuildBundleFileSizes
  • Updates list build endpoint to include relationship info for build bundles

@AvdLee
Copy link
Owner

AvdLee commented Nov 22, 2021

@birwin93 can you merge in latest changes from master?

@birwin93
Copy link
Contributor Author

Done! Although it doesn't look like the checks re-ran. I rebased and did a force push, not sure if that's allowed

@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented Nov 23, 2021

Messages
📖

View more details on Bitrise

📖 No tests found for the current changes

Generated by 🚫 Danger Swift against 49e6ef1

@AvdLee
Copy link
Owner

AvdLee commented Nov 25, 2021

@birwin93 your changes look good, but it would be great to solve the warnings as well. You can use swiftlint autocorrect for this I think!

@birwin93
Copy link
Contributor Author

birwin93 commented Dec 2, 2021

Hmmm @AvdLee I'm a bit confused. This says like the Bitrise check is failing, but when I click on the link it looked like it says it passed?

@AvdLee
Copy link
Owner

AvdLee commented Dec 3, 2021

Hmmm @AvdLee I'm a bit confused. This says like the Bitrise check is failing, but when I click on the link it looked like it says it passed?

Bitrise does not allow to automatically approve open-source builds. I need to manually do this which is why initially builds look like they failed :(

@birwin93
Copy link
Contributor Author

birwin93 commented Dec 3, 2021

Ah great! looks like checks passed, can you approve so we can cut a new release :)

@AvdLee AvdLee merged commit 6961347 into AvdLee:master Dec 6, 2021
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.7.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants