Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual update for users and beta groups #255

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

lvalenta
Copy link
Contributor

@lvalenta lvalenta commented Jan 17, 2024

This MR fixes issues in Apple's API Spec:

  • Added missing user role enum case: GENERATE_INDIVIDUAL_KEYS
  • Updated BetaGroup EP to return array of BetaGroups and not BetaTesters
  • Updated BetaTesters EP to return array of BetaTesters and not Builds.

That may not be all of those issues, just the ones I encountered.

@lvalenta lvalenta requested a review from AvdLee as a code owner January 17, 2024 10:23
@MortenGregersen
Copy link
Contributor

There are more responses with wrong data type. All except the AppCategory ones. I have made the same changes in my library: https://github.com/MortenGregersen/Bagbutik/pull/147/files
If you haven't already, please file feedback to Apple and duplicate my feedback (FB13540097).

Regarding the user role, I have made the same change.
https://github.com/MortenGregersen/Bagbutik/pull/149/files
Again, if you haven't already, please file feedback to Apple and duplicate my feedback (FB13546172).

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for your contribution!

@AvdLee AvdLee merged commit c5a2c8e into AvdLee:master Jan 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants