Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : temperature details api program #100

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

akarshghildyal
Copy link
Contributor

Closes: #49

  • Title : Temperature program
  • Name: Akarsh Ghildyal
  • Idenitfy yourself: SSOC Contributor

Describe the add-ons or changes you've made 📃

I've made a temperature program that asks users to enter an api key and enter the name of the place to view its temperature details along with humidity, pressure, windspeed, condition, feels like temperature
Give a clear description of what have you added or modifications made
I have utilised the weather api to fetch the weather details of a place.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I ran the code locally.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Temperature-Jarvis_.mp4

Note to reviewers 📄

I had to crop the video(top and side) so I used an online editor so it has the watermark.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney
Copy link
Owner

@akarshghildyal until not assigned, don't raise the pr

@Avdhesh-Varshney
Copy link
Owner

rename Temperature Details to Weather Details

@akarshghildyal
Copy link
Contributor Author

@Avdhesh-Varshney I am sorry, I was under the impression that I've been assigned the issue, I should've checked.
I'll make the change now

@akarshghildyal
Copy link
Contributor Author

rename Temperature Details to Weather Details

done

@Avdhesh-Varshney Avdhesh-Varshney merged commit c4e6449 into Avdhesh-Varshney:main Jul 15, 2024
@Avdhesh-Varshney Avdhesh-Varshney added Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Temperature details of any place
2 participants