-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secure passwords #25
Secure passwords #25
Conversation
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krishnasharmak05 don't change db, revoke it. And you have hashing the password but on during login, you have to verifying the password using hash codes?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krishnasharmak05 PR Approved 🎉
Closes #11
Describe the add-ons or changes you've made 📃
Give a clear description of what have you added or modifications made
I have done the following:
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
I throughly tested the changes by creating new users, and logging them in (See screenshot below).
Checklist: ☑️
Screenshots 📷
SignUp testing 👇
Login testing 👇