Added QR Code Generator Program in Jarvis #52 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a QR code Generator markdown
The QR Code Generator Program is added with Perfect UI and User Friendly
|
Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE. |
|
Please merge my PR @Avdhesh-Varshney with the issue #52 |
Avdhesh-Varshney
requested changes
Jul 4, 2024
Avdhesh-Varshney
added
bug 🐛
Changed main() to qrCodeGenerator()
Changed main to qrCodeGenerator
Screen.Recording.2024-07-05.155532.mp4 |
Screen.Recording.2024-07-05.155846.mp4 |
Avdhesh-Varshney
approved these changes
Jul 5, 2024
@vishalmaurya850 only this video is required not the video for setup of project. And program LGTM. |
|
@vishalmaurya850 mention your issue and properly link your issue. Otherwise labels will not attach on merging the pr |
Avdhesh-Varshney
added
Intermediate
|
Which Issue are you talking about @Avdhesh-Varshney |
related to this pr. Properly mention your issue number in the pr template while raising not in the comment section after raising the pr. |
vishalmaurya850
changed the title
|
Ok now it's perfect?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes:
Describe the add-ons or changes you've made 📃
I have updated the requirement.txt file and added a qr code generator program integrated in Jarvis and also updated imageProgram.py file
Type of change ☑️
What sort of change have you made:
How Has This Been Tested? ⚙️
Checklist: ☑️
Screenshots 📷
Note to reviewers 📄