Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculator Integration #91

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Calculator Integration #91

merged 2 commits into from
Jul 9, 2024

Conversation

ChiragAgg5k
Copy link
Contributor

Closes: #80

  • Title : Calculator Integration
  • Name: Chirag Aggarwal
  • Idenitfy yourself: SSOC contributor

Describe the add-ons or changes you've made 📃

  • Added simple calculator.
  • Small update to readme regarding virtual env.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Tested various edge cases such as division by zero.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Screenshot 2024-07-06 at 9 08 48 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 6, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Avdhesh-Varshney
Avdhesh-Varshney requested changes Jul 7, 2024
View reviewed changes
Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiragAgg5k show me a working video

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label Jul 7, 2024
@ChiragAgg5k
Copy link
Contributor Author

@Avdhesh-Varshney Here's a working demo:

Screen.Recording.2024-07-07.at.10.03.27.PM.mov

@Avdhesh-Varshney Avdhesh-Varshney merged commit 0e262ae into Avdhesh-Varshney:main Jul 9, 2024
1 check passed
@Avdhesh-Varshney Avdhesh-Varshney added Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. and removed Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 9, 2024
@ChiragAgg5k ChiragAgg5k deleted the adding-calculator branch July 9, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avdhesh-Varshney Avdhesh-Varshney Avdhesh-Varshney approved these changes

Assignees

@ChiragAgg5k ChiragAgg5k

Labels
Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📃: Calculator Integration
2 participants
@ChiragAgg5k @Avdhesh-Varshney