Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Converter Program #97

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

akarshghildyal
Copy link
Contributor

Closes: #74

  • Title : Unit Converter
  • Name: Akarsh Ghildyal
  • Idenitfy yourself: SSOC Contributor

Describe the add-ons or changes you've made 📃

Added a unit converter program under api programs where users can convert units of the following types Length, Temperature, Area, Volume, Weight, Time
Give a clear description of what have you added or modifications made
Utilized pint library for the unit conversions.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I tested it in my local machine

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

Unit_Converter-Jarvis.mp4

Note to reviewers 📄

for temperature I have mapped Celsius to degree_celsius as the latter is used in the pint library and the former is used in general life with capitalized first letter. Same case with Kelvin and Fahrernheit.
I could not find any free api for this. I referred to the docs

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 11, 2024
@Avdhesh-Varshney Avdhesh-Varshney merged commit 446d18e into Avdhesh-Varshney:main Jul 11, 2024
@Avdhesh-Varshney Avdhesh-Varshney added Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Unit Converter
2 participants