Atl mode should not be default #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcinMiklas
force-pushed
the
atl_mode_should_not_be_default
branch
from
6b51e3a
to
8c9d1d1
Compare
|
What is ATL? Anyone have objections to this MR? |
|
ATL is part of Aquantia NIC support added in: Current cmake/makefiles are pretty messy. It would be good to rewrite them from ground up and make nice cmake configuration/feature options to easily choose what hardware support you want and what sw features you choose. But this is topic for another big PR. Here I am just restoring the linux generic as default compilation option, if no special flags are defined. |
|
Changes look reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.