Bugfixes from the DAQ test #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did not wake up sleeping writers when the mailbox was killed, leading to a possible hang.
And fix warning message in mailbox
We first merge iters of the same kind, then sync different kinds by time, rather than the other way round. This should help avoid deadlocks caused by one kind having much larger chunks than the other, by ensuring the iteration over the small-chunked kind data is symmetric. For example, if you depend on events (large time chunks), peaks, and peak_classification, you might previously ask first for 1000 peaks chunks, then 1000 peak_classification chunks. Now you will ask for 1 peak chunk, 1 peak_cl chunk, 1 peak chunk, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains several bugfixes discovered during the test of the new DAQ, described in the individual commits. Several of these came to light only now due to the somewhat "interesting" waveforms seen in the initial data.
I will likely add to this during this week.