Allow option to be overwritten to allow subclassing #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoranAngevaare
changed the title
WenzDaniel
reviewed
Feb 9, 2021
| @@ -37,7 +37,7 @@ def wrapped(plugin_class): | |||
| # Already have some options set, e.g. because of subclassing | |||
| # where both child and parent have a takes_config decorator | |||
| for opt in result.values(): | |||
| if opt.name in plugin_class.takes_config: | |||
| if opt.name in plugin_class.takes_config and not opt.overwrite: | |||
| raise RuntimeError( | |||
| f"Attempt to specify option {opt.name} twice") | |||
| plugin_class.takes_config = immutabledict({ | |||
There was a problem hiding this comment.
Hej thanks for the changes, one question though. I do not clearly see the overwrite part I have to admit. To me it looks like both options are now in plugin_class.takes_config, but maybe I am wrong. Have you checked the lineage and that the option is propagated to the plugin correctly?
There was a problem hiding this comment.
Hi @WenzDaniel , yes I checked, nevertheless not bad to just add a test: 5fc6f87
WenzDaniel
approved these changes
Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Not allowing options to be overwritten can lead to less clear code than the other way around. See: https://github.com/XENONnT/cutax/issues/3
Can you briefly describe how it works?
Allow an option to be overwritten with the expert flag
overwrite=True.Can you give a minimal working example (or illustrate with a figure)?
Even better! I have a pull request:
https://github.com/XENONnT/cutax/pull/4