Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix digitizer saturation check #464

Merged
merged 1 commit into from Jun 11, 2021

Conversation

zhut19
Copy link
Contributor

@zhut19 zhut19 commented Jun 7, 2021

What is the problem / what does the code in this PR do
Fix a bug that's causing pulse saturation check not working. The right condition should be max_in_record >= int(baseline), as record = int(baseline) - raw_record and pulse saturation results into raw_record = 0

@JoranAngevaare
Copy link
Member

Looking at the code and the dtypes, I think this makes sense, thanks Tianyu.

Do you want me too have a look in the data too or have you found/done sufficient evidence and tests such that you are confident?

Other than that, I think we might want to increment the Peaklets version for this right?

@zhut19
Copy link
Contributor Author

zhut19 commented Jun 8, 2021

Thank @jorana, you are welcome to check, so there's less room for a mistake again. A few more things to do for this to work again (I mean before we bump the Peaklet version).

@JoranAngevaare JoranAngevaare merged commit a8de098 into AxFoundation:master Jun 11, 2021
@zhut19 zhut19 deleted the sat_channel_patch branch August 27, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants