Add select index to compute width #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 9, 2021
|
Hi Tianyu, thanks for the PR. I just had a look at the code and looks fine (only changes for peaks with saturated channels). |
| @@ -68,12 +68,18 @@ def compute_index_of_fraction(peak, fractions_desired, result): | |||
|
|
|||
|
|
|||
| @export | |||
| def compute_widths(peaks): | |||
| def compute_widths(peaks, select_peaks_indices=None): | |||
| """Compute widths in ns at desired area fractions for peaks | |||
There was a problem hiding this comment.
could you update the dosctring to include the select_peaks_indices and what None means?
JoranAngevaare
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
After reconstructing peaklets with saturation correction, we need to update the widths for selected peaklets. For this purpose, I propose to add a
select_peaks_indicieskey to the compute width function.I couldn't find a way to do this without changing this function in strax because numpy structured array assignment is a bit tricky i.e.
arr[index]['x'] = new_valueswill not update the valuesarr['x'][index] = new_valueswill update the values