Fix savewhen issues #648
Merged
Fix savewhen issues #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I drink so little coffee before doing so
2 tasks
Pull Request Test Coverage Report for Build 1837651073
💛 - Coveralls |
|
Hmm I thought we covered everything with the tests added in 631. What have we overlooked? |
|
Some functions that use the lines I changed here and are failing in XENONnT/straxen#879 |
JoranAngevaare
commented
Feb 13, 2022
| for p in self._plugin_class_registry.values() | ||
| for d in p.provides]) | ||
|
|
||
| return {dtype: dict(hash=h, save_when=save_when.name, version=version) |
There was a problem hiding this comment.
issue 1, save_when.name
| @@ -91,9 +91,10 @@ def scan_runs(self: strax.Context, | |||
| + list(self.context_config['check_available']))) | |||
|
|
|||
| for target in check_available: | |||
| p = self._plugin_class_registry[target] | |||
| if p.save_when < strax.SaveWhen.ALWAYS: | |||
| @@ -203,6 +203,7 @@ class PeakClassification(strax.Plugin): | |||
| lone_hits='lone_hits') | |||
| depends_on = ('peaks',) | |||
| rechunk_on_save = True | |||
| save_when = immutabledict({k: strax.SaveWhen.ALWAYS for k in provides}) | |||
There was a problem hiding this comment.
dummy way of testing logic
JoranAngevaare
commented
Feb 13, 2022
Comment on lines
-427
to
+428
| if not self._plugin_class_registry[target].save_when > strax.SaveWhen.NEVER: | ||
| save_when = self.get_save_when(target) | ||
| if save_when == strax.SaveWhen.NEVER: |
WenzDaniel
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some issues introduced in features added in #631
also see XENONnT/straxen#879